Re: [PATCH 01/19] Add XHFC support for embedded Speech-Design board to hfcmulti

[Andi Kleen]

Karsten Keil <keil@xxxxxxxxxxxxx> writes:


> --- a/drivers/isdn/hardware/mISDN/hfc_multi.h
> +++ b/drivers/isdn/hardware/mISDN/hfc_multi.h
> @@ -18,6 +18,46 @@
>  #define	PCI_ENA_MEMIO	0x02
>  
>  /*
> + * Defines for the SDG embedded board using the XHFC-4SU chip
> + */
> +#ifdef CONFIG_8xx

This seems like a awfully generic name for a (likely global) CONFIG. Can you
add a descriptive prefix?

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/