Re: fix rtc_cmos bug

[ye janboe]

my fix is wrong?

Why no one ack this patch?

Thanks

Janboe

2009/5/17 ye janboe <janboe.ye@xxxxxxxxx>:
>    fix  Bug 13326 -  Null pointer dereference in rtc-cmos driver
>    http://bugzilla.kernel.org/show_bug.cgi?id=13326
>
>    Signed-off-by: janboe <janboe.ye@xxxxxxxxx>
>
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index 23e10b6..da132f6 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -1179,7 +1179,9 @@ static int __init cmos_init(void)
>        int retval = 0;
>
>  #ifdef CONFIG_PNP
> -       pnp_register_driver(&cmos_pnp_driver);
> +       retval = pnp_register_driver(&cmos_pnp_driver);
> +       if (retval)
> +               return retval;
>  #endif
>
>        if (!cmos_rtc.dev)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/