Re: [PATCH] x86: add X86_UPDATE_MPTABLE option

From: Yinghai Lu
Date: Mon May 18 2009 - 13:40:39 EST


Bjorn Helgaas wrote:
> On Saturday 16 May 2009 10:44:59 am Yinghai Lu wrote:
>
>> +config X86_UPDATE_MPTABLE
>> + bool "Enable update mptable according to acpi" if ACPI
>> + default n
>> + depends on X86_MPPARSE && ACPI
>
> Is this any use without CONFIG_KEXEC? Maybe it should depend on
> KEXEC as well? Or maybe we don't need a new option at all, and
> could just put this code under CONFIG_KEXEC directly.

If ACPI is not compiled in, we don't need it that too.

>
>> + ---help---
>> + some systems do not have correct mptable. with "update_mptable" or
>> + "alloc_mptable" kernel could try to update mptable according to DSDT.
>> + Then could use kexec to start second kernel (even old) without acpi
>> + support or "acpi=off"
>
> Please use English conventions such as starting sentences with capital
> letters and capitalizing thing like "ACPI."

ok.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/