Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice(

From: Krzysztof Halasa
Date: Mon May 18 2009 - 09:22:24 EST


Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> writes:

>> } else {
>> floppy->blocks = blocks;
>> floppy->block_size = length;
>> floppy->bs_factor = length / 512;
>> if (floppy->bs_factor != 1)
>> - printk(KERN_NOTICE PFX "%s: Warning: "
>> - "non 512 bytes block size not "
>> - "fully supported\n",
>> - drive->name);
>> + pr_notice(PFX "%s: Warning: non 512 bytes block size not fully supported\n",
>>
>
> Again.

(> 80 chars in line)

Though I think most people would agree that the latter is much better,
no?
I think removal (rewording) of this rule has already been agreed upon,
though not exactly yet codified.
--
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/