Re: [patch 06/51] usb-serial: ftdi_sio: fix reference counting offtdi_private

[David Woodhouse]

On Thu, 2009-05-14 at 15:32 -0700, Greg KH wrote:
> 2.6.29-stable review patch.  If anyone has any objections, please let
> us know.
> 
> ------------------
> 
> From: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> 
> commit c45d63202fbaccef7ef7946c03f27f72c809b1cc upstream.
> 
> This patch (as1238) adds proper reference counting for ftdi_sio's
> private data structure.  Without it, the driver will free the
> structure while it is still in use if the user unplugs the serial
> device before closing the device file.
> 
> The patch also replaces a slightly dangerous
> cancel_delayed_work/flush_scheduled_work pair with
> cancel_delayed_work_sync, which is always safer.
> 
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Reported-by: Daniel Mack <daniel@xxxxxxxx>
> Tested-by: Daniel Mack <daniel@xxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

Works for me as long as you include the incremental patch I just sent.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@xxxxxxxxx                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/