RE: [PATCH] LP3971 PMIC regulator driver update

[Liam Girdwood]

On Mon, 2009-05-18 at 13:32 +0200, Marek Szyprowski wrote:
> Hello, 
> 
> On Monday, May 18, 2009 12:15 PM Liam Girdwood wrote:
> 
> > On Fri, 2009-05-15 at 10:20 +0100, Mark Brown wrote:
> > > On Fri, May 15, 2009 at 11:16:19AM +0200, Marek Szyprowski wrote:
> > > > This patch fixes issues reported by Mark Brown in his review of
> > National Semiconductors LP3971
> > > > PMIC regulator driver. It contains:
> > > > - a little code cleanup
> > > > - list_voltage() callback added
> > >
> > > > Reviewed-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> > >
> > > Looks good.
> > >
> > > Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > 
> > Doesn't apply :-
> > 
> > Applying: LP3971 PMIC regulator driver update
> > error: patch failed: drivers/regulator/lp3971.c:91
> > error: drivers/regulator/lp3971.c: patch does not apply
> > Patch failed at 0001 LP3971 PMIC regulator driver update
> > 
> > Could you regenerate against the voltage for-next branch.
> 
> I've checked the
> git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6.git, the
> for-next branch. I looks that all tabs are converted to spaces in my
> previous patch. I've checked again it imho I've posted it properly. Maybe it
> was broken by merge conflicts in Makefile/Kconfig. What should I do in such
> case? Would you revert the broken version or do I need to post a patch for
> it?
> 

I think it broke during merge (my fault). :-/ I'll revert it for now. 

Could you resend and combine the original and update patches into the
one patch.

Thanks

Liam  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/