Re: [PATCH 2/2] driver core:firmware:fix request_firmware_nowait

[Cornelia Huck]

On Sat, 16 May 2009 21:54:18 +0800,
tom.leiming@xxxxxxxxx wrote:

> @@ -646,14 +646,12 @@ request_firmware_nowait(
>  		.uevent = uevent,
>  	};
> 
> -	task = kthread_run(request_firmware_work_func, fw_work,
> -			    "firmware/%s", name);
> -
> -	if (IS_ERR(task)) {
> +	ret = async_run_inatomic(request_firmware_work_func, fw_work);
> +	if (ret) {
>  		fw_work->cont(NULL, fw_work->context);
>  		module_put(fw_work->module);
>  		kfree(fw_work);
> -		return PTR_ERR(task);
> +		return ret;

You change the return code from an usual error code to a boolean value
here...

>  	}
>  	return 0;
>  }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/