Re: [KVM PATCH v2 4/4] kvm: add iosignalfd support

[Avi Kivity]

Gregory Haskins wrote:
> +
> +struct _iosignalfd {
>   

Why the underscore?  It's unorthodox for a structure.

> +	u64                  cookie;
> +	u64                  addr;
> +	size_t               length;
> +	struct file         *file;
> +	struct list_head     list;
> +	struct kvm_io_device dev;
> +};
>   

How will that work with multiple identical addresses and different 
cookies?  Will the code iterate over all of them and just fire for one?

I guess that's the best way for now.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/