Re: [PATCH] ACPI: idle: fix init-time TSC check regression

From: Frans Pop
Date: Fri May 15 2009 - 06:58:01 EST


On Thursday 14 May 2009, Len Brown wrote:
> From: Len Brown <len.brown@xxxxxxxxx>
>
> A previous 2.6.30 patch, a71e4917dc0ebbcb5a0ecb7ca3486643c1c9a6e2,
> (ACPI: idle: mark_tsc_unstable() at init-time, not run-time)
> erroneously disabled the TSC on systems that did not actually
> have valid deep C-states.
>
> Move the check after the deep-C-states are validated,
> via new helper, tsc_check_state(), hich replaces tsc_halts_in_c().
>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>

OK on both my desktop (which had the regression) and laptop.

Tested-by: Frans Pop <elendil@xxxxxxxxx>

(Tested together with the 2 patches you sent later.)

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/