Re: [PATCH] x86: fix system without memory on node0

From: Andi Kleen
Date: Wed May 13 2009 - 03:55:06 EST


> +#if defined(CONFIG_X86_64) && defined(CONFIG_NUMA)
> + /*
> + * make sure boot cpu node_number is right, when boot cpu is on the
> + * node that doesn't have mem installed
> + */
> + per_cpu(node_number, boot_cpu_id) = cpu_to_node(boot_cpu_id);
> +#endif

Seems like a quite crappy hac^wpatch. Why is it ever set to the wrong
value? And why is that only the case on NUMA and 64bit?

-Andi (who is also doubtful that the rest of the system can handle
memory less memory nodes in all cases)

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/