Re: [PATCH block#for-2.6.31] scsi: fix resid_len mis-conversion inscsi_end_request()

From: FUJITA Tomonori
Date: Tue May 12 2009 - 07:33:43 EST


On Tue, 12 May 2009 11:15:22 +0900
Tejun Heo <tj@xxxxxxxxxx> wrote:

> Commit c3a4d78c580de4edc9ef0f7c59812fb02ceb037f introduced
> rq->data_len and converted residual count users to it. While
> converting, it mistakenly converted scsi_end_request() to finish
> requests with residual count when it wants to do is fully complete the
> request. Fix it by using blk_end_request_all() instead.
>
> This bug was spotted by Boaz Harrosh.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Spotted-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
> Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
> Cc: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/scsi/scsi_lib.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)

Looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/