[PATCH] securityfs: securityfs_remove should handle IS_ERR pointers

From: Eric Paris
Date: Mon May 11 2009 - 20:48:43 EST


Both of the securityfs users (TPM and IMA) can call securityfs_remove and pass
an IS_ERR(dentry) in their failure paths. This patch handles those rather
than panicing when it tries to start deferencing some negative memory.

Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
---

security/inode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/security/inode.c b/security/inode.c
index f3b91bf..f7496c6 100644
--- a/security/inode.c
+++ b/security/inode.c
@@ -287,7 +287,7 @@ void securityfs_remove(struct dentry *dentry)
{
struct dentry *parent;

- if (!dentry)
+ if (!dentry || IS_ERR(dentry))
return;

parent = dentry->d_parent;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/