Re: [PATCH 1/2] Char: rocket, fix ASYNC flags

[Alan Cox]

On Fri,  8 May 2009 10:32:43 +0200
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> ASYNC_* flags are not bits, but rather constants, use ilog2 to obtain
> bit positions and stay atomic.

Definitely agree with the bug but it would I think be cleaner to add
ASYNCF_.. (or ASYNCB_.. or similar) that is the bit numbers rather than
use ilog2. That also means we can later delete ASYNC_xxx from the kernel
side to stop people using them unsafely in drivers 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/