Re: [PATCH 3/3] ring-buffer: make cpu buffer entries counter atomic

[Andrew Morton]

On Thu, 30 Apr 2009 22:22:13 -0400 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> @@ -405,7 +405,7 @@ struct ring_buffer_per_cpu {
>  	unsigned long			nmi_dropped;
>  	unsigned long			commit_overrun;
>  	unsigned long			overrun;
> -	unsigned long			entries;
> +	atomic_t			entries;

This switches `entries' from unsigned-64-bit to signed-32-bit.

The signedness thing is just an unfortunate thing with atomic_t and probably
doesn't matter.

The change in size might or might not be a bug - that's for the person
who didn't document the data structure to work out ;)




/*
 * head_page == tail_page && head == tail then buffer is empty.
 */
struct ring_buffer_per_cpu {

the comment refers to vaporfields?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/