Re: ptrace: selinux_bprm_committed_creds: simplify__wake_up_parent() code and s/parent/real_parent/

From: Roland McGrath
Date: Thu Apr 30 2009 - 18:45:19 EST


> Afaics, with this patch the only user of ->parent outside of ptrace.c & co
> is arch/ia64/kernel/mca.c:format_mca_init_stack(). Hopefully ->parent will
> die soon.

Woo! Nice work. That oddball ia64 case is obviously trivial, it just
wants to avoid uninitialized stuff in its task_struct for a
not-really-a-process. With your fixes, it seems certain that ->parent
should never be examined in those tasks. Even so, the extra initialization
doesn't hurt. You could clean it up today with:
tracehook_finish_clone(p, 0, 0);
at the end (in place of touching ->parent).
That will dtrt both now and later.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/