Re: [PATCH 2/5] USB: Provide USB boot device availability notification

[Sergei Shtylyov]

Alan Stern wrote:

> > > +/* The mask of possible USB boot devices depends on what drivers and
> > > + * options have been configured into the kernel.  There are too many
> > > + * USB network config options to list here, so just assume it is always
> > > + * possible to have a USB network device.
> > > + */
> > > +static int usb_bootdev_mask = 0
> > > +#ifdef CONFIG_USB_SERIAL_CONSOLE
> > > +				| BOOTDEV_CONSOLE_MASK
> > > +#endif
> > > +#if defined(CONFIG_USB_STORAGE) | defined(CONFIG_BLK_DEV_UB)

> >    It should be ||, not bitwise | here, no?

> No, it should be bitwise |.  The value being constructed is a union of 
> disjoint mask bits.

   I meant the #if line only. Although it shouldn't matter really...

> Alan Stern

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/