Re: [PATCH] block: remove unused __REQ_NR_BITS

From: Jerome Marchand
Date: Thu Apr 30 2009 - 04:42:47 EST


Hi Nikanth,

Never mind, I missed your patch.

Jerome

Nikanth K wrote:
> Hi Jerome
>
> On Wed, Apr 29, 2009 at 7:31 PM, Jerome Marchand <jmarchan@xxxxxxxxxx> wrote:
>> Removes __REQ_NR_BITS which is not used since its only user
>> (blk_dump_rq_flags()) stopped to use it.
>>
>
> See http://lkml.org/lkml/2009/4/27/140
>
> A user for it is added by a patch in linux-2.6-block#for-2.6.31
> see http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=commit;h=9eb55b030c4b3227334ee4482402096cd1d1a6fe
>
> Thanks
> Nikanth
>
>> Signed-off-by: Jerome Marchand <jmarchan@xxxxxxxxxx>
>> ---
>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>> index 2755d5c..a101821 100644
>> --- a/include/linux/blkdev.h
>> +++ b/include/linux/blkdev.h
>> @@ -119,7 +119,6 @@ enum rq_flag_bits {
>> __REQ_INTEGRITY, /* integrity metadata has been remapped */
>> __REQ_NOIDLE, /* Don't anticipate more IO after this one */
>> __REQ_IO_STAT, /* account I/O stat */
>> - __REQ_NR_BITS, /* stops here */
>> };
>>
>> #define REQ_RW (1 << __REQ_RW)
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/