Re: [PATCH] fs/super.c: fix sparse warning

From: Al Viro
Date: Wed Apr 29 2009 - 20:42:21 EST


On Wed, Apr 29, 2009 at 08:14:57PM -0400, H Hartley Sweeten wrote:
> Sparse reports the following in fs/super.c:
>
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Subrata Modak <subrata@xxxxxxxxxxxxxxxxxx>

Applied.

However, I would *really* ask you to avoid that kind of subjects in
the future. Proper subject for that one is "NULL noise in <file>" (or
<file>:<function>. Sparse doesn't even need to be mentioned.

sparse generates many kinds of warnings. And they are neither equal
nor equally interesting.

Kindly use subjects that would tell what's going on; "$TOOL gives
some warning in $FILE" is bloody useless.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/