Re: [PATCH 5/5] ring-buffer: fix printk output

[Ingo Molnar]

* Valdis.Kletnieks@xxxxxx <Valdis.Kletnieks@xxxxxx> wrote:

> On Tue, 28 Apr 2009 23:20:00 PDT, Andrew Morton said:
> > printk_once() is racy on smp and preempt btw ;)
> 
> Looks like at worst, it's prone to the usual printk racing, plus a 
> possible misfire causing it to print twice before shutting up?  Or 
> is there something I'm missing here?

Yeah, that's the worst-case scenario.

Still worth improving if we can do it without bloating the code or 
data.

[ If not, we can just assume the kernel is perfect and ignore all
  the printk_once() and WARN_ONCE() / WARN_ON_ONCE() callsites as
  obviously dead code ;-) ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/