Re: [PATCH] poll: Avoid extra wakeups in select/poll
From: Ingo Molnar
Date: Wed Apr 29 2009 - 09:11:39 EST
* Eric Dumazet <dada1@xxxxxxxxxxxxx> wrote:
> > should be inline perhaps?
>
> Well, I thought current practice was not using inline for such
> trivial functions, as gcc already inlines them anyway.
ok.
how about:
> > [ I'd still suggest to factor out the guts of do_select() as
> > its nesting is excessive that hurts its reviewability quite a
> > bit - but now your patch does not make the situation any
> > worse. ]
We tend to shop for drive-by cleanups in visibly ugly code whenever
someone wants to touch that code. Could go into a separate patch.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/