Re: [PATCH] crypto: catch base cipher self-test failures in fips mode

From: Jarod Wilson
Date: Wed Apr 29 2009 - 08:39:51 EST


On Wednesday 29 April 2009 06:36:23 Neil Horman wrote:
> On Tue, Apr 28, 2009 at 09:11:51PM -0400, Jarod Wilson wrote:
> > I think this might have already been posted by Neil Horman, and
> > we already have it in the Red Hat Enterprise Linux 5.x kernels,
> > but in fips mode, we need to panic on the base cipher self-tests
> > failing as well as the later tests.
> >
> > Signed-off-by: Jarod Wilson <jarod@xxxxxxxxxx>
> >
> I did post it:
> http://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg02307.html
> looks like it somehow just never made it to Linus. Thanks for noticing, Jarod.

That part got committed, this is an additional piece, as I believe that
wasn't quite complete. This patch adds another check for the rc of
alg_test_cipher() (vs. only the check for alg_test_descs[i].test()).

--
Jarod Wilson
jarod@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/