Re: [PATCH 8/9] x86/irq: make MSI irq_desc numa aware -v3

From: Ingo Molnar
Date: Wed Apr 29 2009 - 08:02:24 EST



* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> >
> >> Ingo Molnar wrote:
> >>> * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> >>>
> >>>> +#ifdef CONFIG_NUMA_IRQ_DESC
> >>>> + /* different node ?*/
> >>>> + if (desc_new->node != node)
> >>>> + desc = move_irq_desc(desc, node);
> >>>> +#endif
> >>> this should have been CONFIG_NUMA_MIGRATE_IRQ_DESC. But even with
> >>> that fixed, CONFIG_NUMA_MIGRATE_IRQ_DESC is _removed_ in the #2
> >>> patch in your series and never reintroduced!
> >> should change that to CONFIG_SPARSE_IRQ
> >
> > That's sensible too.
> >
>
> do you mean add back CONFIG_NUMA_IRQ_DESC?

No, what i thought to be sensible is to make this behavior part of
CONFIG_SPARSE_IRQ=y. We dont want a zillion of config options.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/