Re: [PATCH 22/30] microblaze_mmu_v1: Update linker script for MMU

[Michal Simek]

Arnd Bergmann wrote:
> On Monday 27 April 2009, monstr@xxxxxxxxx wrote:
>> --- a/arch/microblaze/kernel/vmlinux.lds.S
>> +++ b/arch/microblaze/kernel/vmlinux.lds.S
>> @@ -17,8 +17,11 @@ ENTRY(_start)
>>  jiffies = jiffies_64 + 4;
>>  
>>  SECTIONS {
>> +#ifdef CONFIG_MMU
>> +       . = CONFIG_KERNEL_START;
>> +#else
>>         . = CONFIG_KERNEL_BASE_ADDR;
>> -
>> +#endif
>>         .text : {
>>                 _text = . ;
>>                 _stext = . ;
> 
> This change looks a bit bogus, can't you use the same symbol for
> both? I guess either one would be fine, but I don't see a reason
> for them to be different.

It will be possible to set for noMMU kernel
CONFIG_KERNEL_BASE_ADDR is CONFIG_KERNEL_START which can remove it.

CONFIG_KERNEL_START is physical base memory address because of noMMU
KERNEL_BASE_ADDR is 0xC0000000 buf of course could be change in menuconfig.

I'll do some tests.

Thanks,
Michal



> 
> 	Arnd <><


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/