Re: [PATCH 04/29] x86/perfcounters: reworkpmc_amd_save_disable_all() and pmc_amd_restore_all()

[Peter Zijlstra]

On Wed, 2009-04-29 at 12:47 +0200, Robert Richter wrote:
> MSR reads and writes are expensive. This patch adds checks to avoid
> its usage where possible.

save_disable_all()
enable(1)
restore_all()

would not correctly enable 1 with the below modification as we do not
write the configuration into the msr, on which restore relies, as it
only toggles the _ENABLE bit.

That said, I'm not sure if that's really an issue, but its why the does
does as it does.

A better abstraction could perhaps avoid this issue all-together.

> Signed-off-by: Robert Richter <robert.richter@xxxxxxx>
> ---
>  arch/x86/kernel/cpu/perf_counter.c |   24 ++++++++++++++----------
>  1 files changed, 14 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
> index d6d6529..75a0903 100644
> --- a/arch/x86/kernel/cpu/perf_counter.c
> +++ b/arch/x86/kernel/cpu/perf_counter.c
> @@ -334,11 +334,13 @@ static u64 pmc_amd_save_disable_all(void)
>  	for (idx = 0; idx < nr_counters_generic; idx++) {
>  		u64 val;
>  
> +		if (!test_bit(idx, cpuc->active_mask))
> +			continue;
>  		rdmsrl(MSR_K7_EVNTSEL0 + idx, val);
> -		if (val & ARCH_PERFMON_EVENTSEL0_ENABLE) {
> -			val &= ~ARCH_PERFMON_EVENTSEL0_ENABLE;
> -			wrmsrl(MSR_K7_EVNTSEL0 + idx, val);
> -		}
> +		if (!(val & ARCH_PERFMON_EVENTSEL0_ENABLE))
> +			continue;
> +		val &= ~ARCH_PERFMON_EVENTSEL0_ENABLE;
> +		wrmsrl(MSR_K7_EVNTSEL0 + idx, val);
>  	}
>  
>  	return enabled;
> @@ -372,13 +374,15 @@ static void pmc_amd_restore_all(u64 ctrl)
>  		return;
>  
>  	for (idx = 0; idx < nr_counters_generic; idx++) {
> -		if (test_bit(idx, cpuc->active_mask)) {
> -			u64 val;
> +		u64 val;
>  
> -			rdmsrl(MSR_K7_EVNTSEL0 + idx, val);
> -			val |= ARCH_PERFMON_EVENTSEL0_ENABLE;
> -			wrmsrl(MSR_K7_EVNTSEL0 + idx, val);
> -		}
> +		if (!test_bit(idx, cpuc->active_mask))
> +			continue;
> +		rdmsrl(MSR_K7_EVNTSEL0 + idx, val);
> +		if (val & ARCH_PERFMON_EVENTSEL0_ENABLE)
> +			continue;
> +		val |= ARCH_PERFMON_EVENTSEL0_ENABLE;
> +		wrmsrl(MSR_K7_EVNTSEL0 + idx, val);
>  	}
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/