Re: [RFC PATCHSET linux-2.6-block#for-2.6.31] block: lld cleanup patches

[Bartlomiej Zolnierkiewicz]

On Tuesday 28 April 2009 05:44:07 Tejun Heo wrote:
> Hello, Bartlomiej.
> 
> Bartlomiej Zolnierkiewicz wrote:
> > From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> > Subject: [RFC][PATCH] mg_disk: fix issue with data integrity on error in mg_write()
> > 
> > We cannot acknowledge the sector write before checking its status
> > (which is done on the next loop iteration) and we also need to do
> > the final status register check after writing the last sector.
> > 
> > Fix mg_write() to match mg_write_intr() in this regard.
> > 
> > While at it:
> > - add mg_read_one() and mg_write_one() helpers
> > - always use MG_SECTOR_SIZE and remove MG_STORAGE_BUFFER_SIZE
> > 
> > Cc: unsik Kim <donari75@xxxxxxxxx>
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> 
> I folded other three patches into my series.  This one looks good to me
> too but unlike others this one actually changes how the driver
> interacts with the device so I think it would be better to wait for
> unsik's ack on this one (I'm pushing out others).

Fine with me and thanks for handling it.  BTW do you still have version this
patch re-synced on top of other changes around?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/