Re: [PATCH] net/sunrpc/svc_xprt.c: fix sparse warnings

From: J. Bruce Fields
Date: Tue Apr 28 2009 - 13:01:33 EST


On Wed, Apr 22, 2009 at 08:18:19PM -0400, H Hartley Sweeten wrote:
> Fix the following sparse warnings in net/sunrpc/svc_xprt.c.
>
> warning: symbol 'svc_recv' was not declared. Should it be static?
> warning: symbol 'svc_drop' was not declared. Should it be static?
> warning: symbol 'svc_send' was not declared. Should it be static?
> warning: symbol 'svc_close_all' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

Thanks, applied for 2.6.31.--b.

>
> ---
>
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index c200d92..f200393 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -11,6 +11,7 @@
> #include <net/sock.h>
> #include <linux/sunrpc/stats.h>
> #include <linux/sunrpc/svc_xprt.h>
> +#include <linux/sunrpc/svcsock.h>
>
> #define RPCDBG_FACILITY RPCDBG_SVCXPRT
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/