Re: [PATCH 11/14] powerpc: Use macros for .data.page_alignedsection.

From: Stephen Rothwell
Date: Tue Apr 28 2009 - 11:14:34 EST


Hi Tim,

Firstly, patches for a particular architecture should really be cc'd to
the list associated with that architecture. In this case,
linuxppc-dev@xxxxxxxxxx (cc'd).

On Mon, 27 Apr 2009 16:33:05 -0400 Tim Abbott <tabbott@xxxxxxx> wrote:
>
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -222,6 +222,7 @@ SECTIONS
>
> #ifdef CONFIG_PPC32
> .data : AT(ADDR(.data) - LOAD_OFFSET) {
> + PAGE_ALIGNED_DATA
> DATA_DATA
> *(.sdata)
> *(.got.plt) *(.got)
> @@ -259,11 +260,6 @@ SECTIONS
> *(.data.init_task)
> }
>
> - . = ALIGN(PAGE_SIZE);
> - .data.page_aligned : AT(ADDR(.data.page_aligned) - LOAD_OFFSET) {
> - *(.data.page_aligned)
> - }
> -

This moves the page_aligned section from a common part of the
vmlinux.lds to a 32 bit only part. Was that intentional?

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature