Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable withirqs enabled

[Hans-Christian Egtvedt]

On Sat, 25 Apr 2009 02:06:12 +0900 (JST)
Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:

> On Sat, 25 Apr 2009 01:48:50 +0900 (JST), Atsushi Nemoto
> <anemo@xxxxxxxxxxxxx> wrote:
> > Here is a possible example:
> > 
> > 1. RTC alarm interrupt handler takes rtc->irq_lock by spin_lock()
> > 2. A timer interrupt handler calls rtc_uie_timer() for UIE emulation
> > 3. rtc_uie_timer() waits on rtc->irq_lock .... deadlock!
> 
> Oops, this is wrong.  This deadlock cannot happen since
> rtc_uie_timer() will be called in bh (softirq) context, not interrupt
> context.
> 
> Anyway, I just posted updated patch.  Please take a look.  Thanks.
> 

AVR32 has interrupts disabled during the interrupt handler, so AFAICT
the rtc-at32ap700x.c should be fine.

-- 
Best regards,
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/