Re: [PATCH 5/5] add ksm kernel shared memory driver.

From: Andrew Morton
Date: Mon Apr 27 2009 - 18:40:06 EST


On Mon, 20 Apr 2009 04:36:06 +0300
Izik Eidus <ieidus@xxxxxxxxxx> wrote:

> Ksm is driver that allow merging identical pages between one or more
> applications in way unvisible to the application that use it.
> Pages that are merged are marked as readonly and are COWed when any
> application try to change them.

Breaks sparc64 and probably lots of other architectures:

mm/ksm.c: In function `try_to_merge_two_pages_alloc':
mm/ksm.c:697: error: `_PAGE_RW' undeclared (first use in this function)

there should be an official arch-independent way of manipulating
vma->vm_page_prot, but I'm not immediately finding it.

An alternative (and quite inferior) "fix" would be to disable ksm on
architectures which don't implement _PAGE_RW. That's most of them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/