[PATCH -tip:kill-the-BKL] remove the BKL: remove "BKL auto-drop" assumption from ext3_remount()

From: Alessio Igor Bogani
Date: Mon Apr 27 2009 - 16:22:47 EST


Fix ext3_remount()'s "schedule() drops the BKL automatically" assumption,
when ext3_mark_recovery_complete(), which can sleep, does not do that it can
lock up.

Signed-off-by: Alessio Igor Bogani <abogani@xxxxxxxxxx>
---
fs/ext3/super.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index dc905f9..5d61a7f 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -2503,6 +2503,7 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
#ifdef CONFIG_QUOTA
int i;
#endif
+ int bkl = kernel_locked();

/* Store the original options */
old_sb_flags = sb->s_flags;
@@ -2561,9 +2562,13 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
* We have to unlock super so that we can wait for
* transactions.
*/
+ if (bkl)
+ unlock_kernel();
unlock_super(sb);
ext3_mark_recovery_complete(sb, es);
lock_super(sb);
+ if (bkl)
+ lock_kernel();
} else {
__le32 ret;
if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb,
--
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/