Re: [PATCH] Acer Aspire One Fan Control

[Peter Feuerer]

Hi Joe,

thanks for your email. A modified patch will follow soon.

> > + *  25-April-2009: Version 0.5:
> > + *  - ported to 2.6.30
> > + *  - removed kthread and used polling of thermal api
>
> Version information in comments isn't generally useful

Will remove it.

> There's no other thermal device_mode state than ENABLED/DISABLED.
> Maybe just if/else?

Yes will do it.

> > +/* print the name of the trip point */
> > +static int get_trip_type(struct thermal_zone_device *thermal,
> > +		int trip, enum thermal_trip_type *type)
> > +{
> > +	if (trip == 0)
> > +		*type = THERMAL_TRIP_ACTIVE;
> > +	return 0;
> > +}
>
> Comment doesn't match code.  I see no printing here.

Old comment, will correct it.

> You would #define pr_fmt(fmt) "acerhd: " fmt
> instead of prefixing all the printks with "acerhd:"

Jip, will do something like this.

kind regards,
--peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/