Re: [git patches] Staging: rtxxx0: cleanup and "dumb" merge

From: Bartlomiej Zolnierkiewicz
Date: Mon Apr 27 2009 - 11:24:37 EST


On Sunday 26 April 2009 20:39:54 Greg KH wrote:
> On Sun, Apr 26, 2009 at 05:59:20PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >
> > Hi,
> >
> > This patchset cleans up rt{286,287,307}0 drivers (66 KLOC removed) and then
> > "dumb" (i.e. rt3070 shares code with rt2870 by including rt2870's .c files
> > and depends on ifdefs to get the correct end result) merges them (142 KLOC
> > removed). All in all 208 KLOC are gone and we now use the common code for
> > all three Ralink drivers.
>
> Wonderful!
>
> Were you able to test that this still works afterward?

I just used some semi-automatic verification of changes -- I scripted build
process with comparing sizes of resulting .o files so when they were different
I was re-auditing the given patch or (if re-audit didn't catch anything)
comparing corresponding .s files. This of course doesn't provide us with
a complete proof that changes are correct but increases probability of such
outcome significantly. :)

The real testing with RT2860, RT2870 & RT3070 would be much welcomed...

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/