Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update

[Arnd Bergmann]

On Monday 27 April 2009, Michal Simek wrote:
> >       long            st_size;        /* Size of file, in bytes.  */
> 
> Maybe unsigned? Make more sense to me that file size is not minus.
> And for some types below.

st_size represents an off_t in user space, which is signed.
Just over half the existing architectures use signed types
for st_size, but for this (like Sam's suggestion for __u64),
I don't think it matters either way.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/