Re: [PATCH 14/15] x86: convert to use __HEAD and HEAD_TEXT macros.

[Ingo Molnar]

* Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:

> On Mon, Apr 27, 2009 at 06:59:10AM +0200, Ingo Molnar wrote:
> > 
> > * Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> > 
> > > > As mentioned, though, the much more interesting case would be 
> > > > the _real_ kernel vmlinux.lds.S file, which is a lot more 
> > > > complex and where the differences between 32-bit and 64-bit 
> > > > cases aren't totally trivial.
> > > 
> > > Agreed.
> > > 
> > > But I expect someone else to do so.
> > > When I am in unification mode I try to spend time on
> > > architectures with less people involved.
> > 
> > thanks for reconsidering - and i've applied your patch - thanks Sam.
> > 
> > Architectures with lots of people involved (hm, what a strange 
> > way to say 'x86' ;-) tend to be logistically more complex and 
> > there's an (understandably) stronger pushback against 
> > regressions - but that is also where unification is actually 
> > needed the most and where the ongoing costs of splintered code 
> > is the highest.
>
> Well - the effort done for sparc and m68k lately was also needed.
> 
> > Your kbuild patches are making quite a bit of difference so 
> > please dont hold back :)
>
> The good patches are the ones that benefits all architectures.

The good patches are the ones that increase the quality of the 
kernel and benefit people.

In terms of architecture code that means factoring out common code 
and stemming the spread of architecture-specific local hacks.

For details that are inherently per arch - obviously improving the 
more frequently used architectures helps more people, on average.

> Well - I can give the vmlinux_*.ds files a try.
> Did you apply the patch to an append only branch or may I recreate
> the patch?
> I noticed a few minor things that can be 'fixed' to bring the inital
> differences between 32 bit and 64 bit down.
> 
> But I can do these in a follow-up patch too.

Yeah, please do a follow-up patch - unless the first patch is 
outright wrong. I've got a fair amount of test-time in the first 
patch already - and Linus's is on top of it so it would mean a 
rebase of both.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/