Re: [patch 00/27] [rfc] vfs scalability patchset

From: Al Viro
Date: Sat Apr 25 2009 - 15:31:57 EST


On Sat, Apr 25, 2009 at 12:08:16PM -0700, Eric W. Biederman wrote:

> Can we? My first glance at that code I asked myself if we could examine
> i_writecount, instead of going to the file. My impression was that we
> were deliberately only counting persistent write references from files

No, there's nothing deliberate about that. The code is simply wrong;
some of that crap had been fixed with mnt_want_write series, but
the rest...

> instead of transient write references. As only the persistent write
> references matter. Transient write references can at least in theory
> be flushed as the filesystem is remounting read-only.

No. It's far too painful to do and no fs is doing that. You are looking
for deliberate behaviour in a place where we have a half-fixed pile of races.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/