Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable withirqs enabled

From: Alessandro Zummo
Date: Fri Apr 24 2009 - 07:13:47 EST


On Fri, 24 Apr 2009 04:10:51 -0700
David Brownell <david-b@xxxxxxxxxxx> wrote:

> >  use spin_lock() in the IRQ handler and spin_lock_irq/irq_save
> >  in the setup functions.
>
> I think you're describing how the *current* scheme is supposed
> to work ... except that some IRQ handlers aren't calling the
> rtc_update_irq() routine with IRQs blocked.
>
> Yes, that current scheme works ... modulo those buggy handlers.

ok, but why it's necessary to disable the interrupts? Only because
the specs says so or because there's a locking issue I'm missing?

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/