Re: [PATCH] X86-32: Let gcc decide whether to inline memcpy was Re: New x86 warning

[Andi Kleen]

> gcc 4.2.4 - withOUT memset patch: 20
> gcc 4.2.4 - with memset patch: 365
> 
> gcc 3.4 - withOUT memset patch: 17
> gcc 3.4 - with memset patch: 349

Yes it sounds like 3.4 is worse on that than 3.2. Too bad.

> I'm guessing this is probably not acceptable, so I won't bother

It depends if the calls are in critical code. Or how big they
are (for a 1K memset it's totally fine to have it out of line).

For example for any memsets in __init functions we wouldn't
care. You could filter those out. And perhaps eyeball the code.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/