Re: [PATCH] ACPI/hpet: prevent boot hang when hpet=force used onICH-4M

From: Ingo Molnar
Date: Fri Apr 24 2009 - 02:37:57 EST



* Len Brown <lenb@xxxxxxxxxx> wrote:

> From: Len Brown <len.brown@xxxxxxxxx>
>
> Linux tells ICH4 users that they can (manually) invoke
> "hpet=force" to enable the undocumented ICH-4M HPET.
> The HPET becomes available for both clocksource and clockevents.
>
> But as of ff69f2bba67bd45514923aaedbf40fe351787c59
> (acpi: fix of pmtimer overflow that make Cx states time incorrect)
> the HPET may be used via clocksource for idle accounting, and
> hpet=force on an ICH4 box hangs boot.
>
> It turns out that touching the MMIO HPET withing
> the ARB_DIS part of C3 will hang the hardware.
>
> The fix is to simply move the timer access outside
> the ARB_DIS region. This is a no-op on modern hardware
> because ARB_DIS is no longer used.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=13087

Nice fix! This moots the other half-quirk patch you wrote for hpet,
right?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/