Re: [PATCH] usb/host/ohci-hcd.c: fix sparse warnings

[Greg KH]

On Wed, Apr 22, 2009 at 01:50:56PM -0400, H Hartley Sweeten wrote:
> On Wednesday, April 22, 2009 10:42 AM, Greg KH wrote:
> > On Wed, Apr 22, 2009 at 01:39:34PM -0400, H Hartley Sweeten wrote:
> >> On Tuesday, April 21, 2009 10:53 PM, Greg KH wrote:
> >>> On Wed, Apr 15, 2009 at 10:04:17PM -0400, H Hartley Sweeten wrote:
> >>> Fix sparse warnings in drivers/usb/host/ohci-hcd.c.
> >>>> 
> >>>> 	warning: symbol 'temp' shadows an earlier one
> >>>> 
> >>>> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> >>>
> >>> I'm not seeing this sparse warning either.
> >>>
> >>> And you didn't fix the two sparse warnings I am seeing in this file,
> >>> so I'm going to think this patch doesn't really do anything :(
> >> 
> >> Following are the sparse warnings I am seeing when building for an
> >> EP93xx ARM platform:
> >
> > Ah, on ARM, sorry, I was building on x86.
> >
> > Care to respin this one, and your other one without the whitespace
> > changes and line-wraps and resend them?
> 
> Not a problem. I will have to attach the patches to avoid the
> line-warps.
> It appears that the wrapping is occurring when my emails be bounced thru
> one of my ISP's servers. I'm still trying to resolve that.
> 
> Question: How do you do a git diff and keep the whitespace changes out?

Don't do the whitespace changes in the first place :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/