Re: [PATCH 18/22] Use allocation flags as an index to the zonewatermark

From: Dave Hansen
Date: Wed Apr 22 2009 - 13:47:22 EST


On Wed, 2009-04-22 at 18:14 +0100, Mel Gorman wrote:
> Preference of taste really. When I started a conversion to accessors, it
> changed something recognised to something new that looked uglier to me.
> Only one place cares about the union enough to access is via an array so
> why spread it everywhere.

Personally, I'd say for consistency. Someone looking at both forms
wouldn't necessarily know that they refer to the same variables unless
they know about the union.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/