Re: [PATCH 1/2 v3] tracing/events: provide string with undefinedsize support
From: Ingo Molnar
Date: Wed Apr 22 2009 - 06:41:24 EST
* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Wed, 22 Apr 2009, Frederic Weisbecker wrote:
>
> > Thanks!
> > Then, may be I should wait for Ingo's pull (if he accepts)
> > before sending a delta to add the parenthesis around __get_str().
>
> It would probably be better to just make the fix now. Just put the
> fix in a separate branch to avoid race conditions (if Ingo already
> did a pull ;-)
Yeah - doing a -v2 (-v3, -v4 ;-) COW branch and then removing them
once they served their purpose does the trick here.
While i generally dont get surprised (negatively ;) by seeing more
(or less) stuff in a branch than expected from the pull request (i
review it all anyway), it's good to practice the COW pull workflow
so that if you send stuff to Linus or others who expect COW there's
no mistakes.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/