Re: [PATCH -v2] Add MCE support to KVM

From: Anthony Liguori
Date: Sat Apr 18 2009 - 16:46:51 EST


Huang Ying wrote:
The related MSRs are emulated. MCE capability is exported via
extension KVM_CAP_MCE and ioctl KVM_X86_GET_MCE_CAP_SUPPORTED. A new
vcpu ioctl command KVM_X86_SETUP_MCE is used to setup MCE emulation
such as the mcg_cap. MCE is injected via vcpu ioctl command
KVM_X86_SET_MCE. Extended machine-check state (MCG_EXT_P) and CMCI are
not simulated.

Maybe I'm missing something, but couldn't this be implemented entirely within userspace? There's nothing VT/SVM specific about this. If the issue is setting these MSRs from userspace via KVM_SET_MSRS isn't enough, perhaps we should add userspace MSR handling.

Also, if you implement the MSR logic in userspace, it's pretty simple to make it work in the non-TCG case which will be a requirement for upstream merging.

Regards,

Anthony LIguori

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/