Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze
From: Grant Likely
Date: Fri Apr 17 2009 - 02:58:22 EST
On Thu, Apr 16, 2009 at 11:01 PM, John Williams
<john.williams@xxxxxxxxxxxxx> wrote:
> On Thu, Apr 16, 2009 at 7:56 PM, <monstr@xxxxxxxxx> wrote:
>> From: Michal Simek <monstr@xxxxxxxxx>
>>
>> Signed-off-by: Michal Simek <monstr@xxxxxxxxx>
>
> ACK from a MicroBlaze perspective, but some other comments below:
Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
But I'm not sure who should pick this up.
>
> A note more for the Xilinx PPC folks (ie Grant Likely):
>
> Shouldn't some of these Kconfig depends for PPC be unified? We have:
>
>> config XILINX_SYSACE
>> tristate "Xilinx SystemACE support"
>> - depends on 4xx
>> + depends on 4xx || MICROBLAZE
>
>> config XILINX_HWICAP
>> tristate "Xilinx HWICAP Support"
>> - depends on XILINX_VIRTEX
>> + depends on XILINX_VIRTEX || MICROBLAZE
>
>
>> config GPIO_XILINX
>> bool "Xilinx GPIO support"
>> - depends on PPC_OF
>> + depends on PPC_OF || MICROBLAZE
>> help
>> Say yes here to support the Xilinx FPGA GPIO device
>
> Are these all really different options? PPC_OF? XILINX_VIRTEX? 4xx?
xsysace should just depend on either PPC or OF. It is applicable to
more than just virtex/spartan systems (I know of at least one
non-virtex 440 board with a systemace, hence the 4xx usage), and it is
conceivable that it would be used on other architectures.
XILINX_VIRTEX makes some sense for hwicap
PPC_OF doesn't have any real meaning anymore. PPC would be better.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/