[PATCH, RFC] check for frozen filesystems in the mmap path

From: Eric Sandeen
Date: Thu Apr 16 2009 - 19:45:54 EST


Stephen Tweedie mentioned to me a concern that while a filesystem
is frozen, data could be dirtied for it via mmap, thereby using
up enough memory that the unfreeze process may be stuck trying
to allocate memory by writing back mmap-dirty data to the frozen
fs.

Christoph suggested maybe a check_frozen in the mmap path to
prevent this; does the sort of thing below look sane?

signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

Index: linux-2.6/mm/memory.c
===================================================================
--- linux-2.6.orig/mm/memory.c
+++ linux-2.6/mm/memory.c
@@ -1944,6 +1944,7 @@ static int do_wp_page(struct mm_struct *
* read-only shared pages can get COWed by
* get_user_pages(.write=1, .force=1).
*/
+ vfs_check_frozen(old_page->mapping->host->i_sb, SB_FREEZE_WRITE);
if (vma->vm_ops && vma->vm_ops->page_mkwrite) {
struct vm_fault vmf;
int tmp;
@@ -2660,6 +2661,7 @@ static int __do_fault(struct mm_struct *
* address space wants to know that the page is about
* to become writable
*/
+ vfs_check_frozen(vmf.page->mapping->host->i_sb, SB_FREEZE_WRITE);
if (vma->vm_ops->page_mkwrite) {
int tmp;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/