Re: microcode driver newly spews warnings
From: H. Peter Anvin
Date: Thu Apr 16 2009 - 19:30:56 EST
Jeff Garzik wrote:
Jeff, did this do the trick for you?
Yes -- but I worry about keeping sysfs files around too long?
Jeff
OK, what isn't clear to me is what the proper return value is in this
case. In particular, how with the caller react to mc_sysdev_add()
returning a nonzero value, but still have the sysdev devices created and
retained?
What I would expect happen would be that sysdev_register_driver() would
return an error and we would unregister the notifier, which really isn't
the right thing -- if the intent is to keep the sysdev devices around
for a possible later update then we should presumably return zero there,
i.e. ignore the return value from microcode_init_cpu(); completely?
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/