Re: [PATCH] block/genhd.c: fix sparse warning

From: Vegard Nossum
Date: Thu Apr 16 2009 - 03:24:10 EST


2009/4/16 Al Viro <viro@xxxxxxxxxxxxxxxxxx>:
> On Thu, Apr 16, 2009 at 06:46:32AM +0200, Vegard Nossum wrote:
>> 2009/4/16 H Hartley Sweeten <hartleys@xxxxxxxxxxxxxxxxxxx>:
>> > Fix sparse warning in block/genhd.c.
>> >
>> > ?? ?? ?? ??warning: symbol '__mptr' shadows an earlier one
>> >
>> > Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>>
>> Hi,
>>
>> Just a heads up: There seems to be some sort of consensus that this
>> type of patch title is not a very good one. (What about "remove
>> variable shadowing"?)
>
> Indeed. ÂSpeaking of other kind of unpleasantness, could you please
> configure your mail-luser-agent to *NOT* replace tabs with series
> of spaces/nbsp? ÂThat crap is very annoying - these strings of
> U+00A0 U+00A0 U+00A0 et sodding cetera are gratuitously making life
> painful for non-UTF8 terminals.

Oh, was that my fault?

That's strange, is this something new in Gmail? Can't remember seeing
this before. It seems that something changed; compare:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

before to

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

...hm...

I'll try to fix it, thanks.


Vegard

--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/