Re: [tree] latest kill-the-BKL tree, v12

From: Alexander Beregalov
Date: Wed Apr 15 2009 - 18:59:01 EST


2009/4/14 Ingo Molnar <mingo@xxxxxxx>:
>
> * Alexander Beregalov <a.beregalov@xxxxxxxxx> wrote:
>
>> On Tue, Apr 14, 2009 at 05:34:22AM +0200, Frederic Weisbecker wrote:
>> > Ingo,
>> >
>> > This small patchset fixes some deadlocks I've faced after trying
>> > some pressures with dbench on a reiserfs partition.
>> >
>> > There is still some work pending such as adding some checks to ensure we
>> > _always_ release the lock before sleeping, as you suggested.
>> > Also I have to fix a lockdep warning reported by Alessio Igor Bogani.
>> > And also some optimizations....
>> >
>> > Thanks,
>> > Frederic.
>> >
>> > Frederic Weisbecker (3):
>> > Â kill-the-BKL/reiserfs: provide a tool to lock only once the write lock
>> > Â kill-the-BKL/reiserfs: lock only once in reiserfs_truncate_file
>> > Â kill-the-BKL/reiserfs: only acquire the write lock once in
>> > Â Â reiserfs_dirty_inode
>> >
>> > Âfs/reiserfs/inode.c     |  10 +++++++---
>> > Âfs/reiserfs/lock.c     Â|  26 ++++++++++++++++++++++++++
>> > Âfs/reiserfs/super.c     |  15 +++++++++------
>> > Âinclude/linux/reiserfs_fs.h | Â Â2 ++
>> > Â4 files changed, 44 insertions(+), 9 deletions(-)
>> >
>>
>> Hi
>>
>> The same test - dbench on reiserfs on loop on sparc64.
>>
>> [ INFO: possible circular locking dependency detected ]
>> 2.6.30-rc1-00457-gb21597d-dirty #2
>
> I'm wondering ... your version hash suggests you used vanilla
> upstream as a base for your test. There's a string of other fixes
> from Frederic in tip:core/kill-the-BKL branch, have you picked them
> all up when you did your testing?
>
> The most coherent way to test this would be to pick up the latest
> core/kill-the-BKL git tree from:
>
> Â git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git core/kill-the-BKL
>

I did not know about this branch, now I am testing it and
there is no more problem with that testcase (dbench).

I will continue testing.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/