Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()

[Ingo Molnar]

* David Howells <dhowells@xxxxxxxxxx> wrote:

> I'd like Linus to pull my first patch, if he will.  That'll at 
> least allow FRV to build.  Could you review it?  That's the email 
> that started this thread, ensubjected:
> 
> 	[PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()

hm, this moves the section defines from a generic header into 
platform headers in essence - not a good move IMO.

Why not start a new linux/percpu_types.h header with just those 
defines in place, include it both from linux/percpu.h and from all 
the asm*/percpu.h files you modify in that patch?

This would fix your build problem minimally - and it would also seed 
the new percpu_types.h file that could start the untangling of this 
dependency hell.

(it would also be much easier to verify for correctness - you just 
move bits and include it trivially in places that need it.)

Am i missing something?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/