Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()

[Linus Torvalds]

On Wed, 15 Apr 2009, David Howells wrote:
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Hmm. Why not move it all above the '#include <asm/percpu.h>'?
> 
> There are circular dependencies between the x86 arch headers that both use
> this and are used to implement this, and it's a bit fragile.

Grr. Indeed it seems to be. Nasty. Header files seem to want that 
DECLARE_PER_CPU() thing without all the other baggage that is implied by 
including all of <linux/percpu.h>, so they just include <asm/percpu.h> 
directly instead.

What a mess.

So maybe we could move DEFINE_PER_CPU in there too? It's less than 
perfect, but at least we'd have things together rather than split in 
really odd ways.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/