Re: [PATCH v2 2/4] ftrace: introduce workqueue_handler_exittracepoint and rename workqueue_execution to workqueue_handler_entry

[Ingo Molnar]

* Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> > >  		lock_map_acquire(&lockdep_map);
> > > +		trace_workqueue_handler_entry(cwq->thread, work);
> > >  		f(work);
> > > +		trace_workqueue_handler_exit(cwq->thread, work);
> 
> This doesn't look right. We must not use "work" after f(work). 
> work->func() can kfree its work.

We can use it as long as we use it as a 'cookie' - i.e. an 
identifier for visualization/statistics, but dont actually 
dereference it, right?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/